linux-kernel - RE: [PATCH] Checks for Null return of skb_alloc in send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <003201cf8a41$1263a020$372ae060$@opengridcomputing.com>
Date:	Tue, 17 Jun 2014 10:30:30 -0500
From:	"Steve Wise" <swise@...ngridcomputing.com>
To:	"'Nicholas Krause'" <xerofoify@...il.com>, <swise@...lsio.com>
Cc:	<roland@...nel.org>, <sean.hefty@...el.com>,
	<hal.rosenstock@...il.com>, <linux-rdma@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] Checks for Null return of skb_alloc in send_flowc



> -----Original Message-----
> From: Nicholas Krause [mailto:xerofoify@...il.com]
> Sent: Tuesday, June 17, 2014 10:25 AM
> To: swise@...lsio.com
> Cc: roland@...nel.org; sean.hefty@...el.com; hal.rosenstock@...il.com; linux-
> rdma@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: [PATCH] Checks for Null return of skb_alloc in send_flowc
> 
> Signed-off-by: Nicholas Krause <xerofoify@...il.com>
> ---
>  drivers/infiniband/hw/cxgb4/cm.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
> index 5e153f6..7e3d663 100644
> --- a/drivers/infiniband/hw/cxgb4/cm.c
> +++ b/drivers/infiniband/hw/cxgb4/cm.c
> @@ -457,6 +457,10 @@ static void send_flowc(struct c4iw_ep *ep, struct sk_buff *skb)
>  	int i;
> 
>  	skb = get_skb(skb, flowclen, GFP_KERNEL);
> +	if (!skb) {
> +		kfree_skb(skb);
> +		pr_warn(MOD "%s failed to allocate skb.\n", __func__);
> +	}

You still don't have this right.  :( 

Like this:

diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
index 5e153f6..3c55e88 100644
--- a/drivers/infiniband/hw/cxgb4/cm.c
+++ b/drivers/infiniband/hw/cxgb4/cm.c
@@ -457,6 +457,8 @@ static void send_flowc(struct c4iw_ep *ep, struct sk_buff *skb)
        int i;

        skb = get_skb(skb, flowclen, GFP_KERNEL);
+       if (!skb)
+               return;
        flowc = (struct fw_flowc_wr *)__skb_put(skb, flowclen);

        flowc->op_to_nparams = cpu_to_be32(FW_WR_OP(FW_FLOWC_WR) |



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/