lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20140617154730.GA14153@kroah.com>
Date:	Tue, 17 Jun 2014 08:47:30 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Jeff Liu <jeff.liu@...cle.com>
Cc:	Christoph Lameter <cl@...two.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Pekka Enberg <penberg@...nel.org>,
	Matt Mackall <mpm@...enic.com>, benh@...nel.crashing.org,
	paulus@...ba.org, schwidefsky@...ibm.com,
	heiko.carstens@...ibm.com, herbert@...dor.apana.org.au,
	davem@...emloft.net, stefanr@...6.in-berlin.de, joro@...tes.org,
	jejb@...isc-linux.org, deller@....de, bhelgaas@...gle.com,
	clm@...com, Josef Bacik <jbacik@...com>, swhiteho@...hat.com,
	bharrosh@...asas.com, bhalevy@...marydata.com, ccaulfie@...hat.com,
	teigland@...hat.com, Theodore Ts'o <tytso@....edu>,
	adilger.kernel@...ger.ca, jaegeuk@...nel.org,
	cm224.lee@...sung.com, Mark Fasheh <mfasheh@...e.com>,
	Joel Becker <jlbec@...lplan.org>, casey@...aufler-ca.com,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 01/24] kobject: return actual error on kset_create_and_add

On Tue, Jun 17, 2014 at 10:25:59PM +0800, Jeff Liu wrote:
> From: Jie Liu <jeff.liu@...cle.com>
> 
> It's better to return the actual error rather than NULL because
> kset_register() can failed due to other reasons.

Why?

Who really cares about that?  What can do you do with that additional
information that will help anything out?

In other words, what benifit does this patch create to justify the large
churn it is going to cause?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ