lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAErSpo7pAv=v7JQp2UoNxYN8Pdj788NPP8OsLkM3p8NuwL_6Wg@mail.gmail.com> Date: Tue, 17 Jun 2014 10:11:44 -0600 From: Bjorn Helgaas <bhelgaas@...gle.com> To: Jiang Liu <jiang.liu@...ux.intel.com> Cc: Benjamin Herrenschmidt <benh@...nel.crashing.org>, Thomas Gleixner <tglx@...utronix.de>, Grant Likely <grant.likely@...aro.org>, Ingo Molnar <mingo@...hat.com>, "H. Peter Anvin" <hpa@...or.com>, "Rafael J. Wysocki" <rjw@...ysocki.net>, Randy Dunlap <rdunlap@...radead.org>, Yinghai Lu <yinghai@...nel.org>, Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>, Andrew Morton <akpm@...ux-foundation.org>, Tony Luck <tony.luck@...el.com>, Joerg Roedel <joro@...tes.org>, Paul Gortmaker <paul.gortmaker@...driver.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, "x86@...nel.org" <x86@...nel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>, "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org> Subject: Re: [RFC Patch V2 08/16] PCI: kill wrong warning message in pcieport driver Please pay attention to the existing convention of changelog summaries (email subject lines), including spacing and capitalization. "git log --oneline drivers/pci/pcie" is a good way to see the pattern. In this case, you could use something like this: PCI/portdrv: Remove warning about invalid IRQ On Mon, Jun 16, 2014 at 11:29 PM, Jiang Liu <jiang.liu@...ux.intel.com> wrote: > For hot-added PCIe ports, it always generates a warning message on x86 > platforms when binding to pcieport driver as: > "device [8086:0e0b] has invalid IRQ; check vendor BIOS". > > It's due to that we check pci_dev->irq before actually allocating IRQ > number for the PCI device: > if (!dev->irq && dev->pin) { > dev_warn(&dev->dev, "device [%04x:%04x] has invalid IRQ; " > "check vendor BIOS\n", dev->vendor, dev->device); > } > status = pcie_port_device_register(dev); > -->pci_enable_device(dev); > -->pci_enable_device_flags() > -->do_pci_enable_device() > -->pcibios_enable_device() > -->pcibios_enable_irq() > > This warning message isn't generated for PCIe ports present at boot time > because x86 arch code has called acpi_pci_irq_enable() in pci_acpi_init() > for each PCI device for safety. > > Signed-off-by: Jiang Liu <jiang.liu@...ux.intel.com> > --- > drivers/pci/pcie/portdrv_pci.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/pci/pcie/portdrv_pci.c b/drivers/pci/pcie/portdrv_pci.c > index 0d8fdc48e642..0e35f9670066 100644 > --- a/drivers/pci/pcie/portdrv_pci.c > +++ b/drivers/pci/pcie/portdrv_pci.c > @@ -203,10 +203,6 @@ static int pcie_portdrv_probe(struct pci_dev *dev, > (pci_pcie_type(dev) != PCI_EXP_TYPE_DOWNSTREAM))) > return -ENODEV; > > - if (!dev->irq && dev->pin) { > - dev_warn(&dev->dev, "device [%04x:%04x] has invalid IRQ; " > - "check vendor BIOS\n", dev->vendor, dev->device); > - } This needs to be rebased to v3.16-rc1. > status = pcie_port_device_register(dev); > if (status) > return status; > -- > 1.7.10.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists