lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 17 Jun 2014 12:14:47 -0400 From: Tejun Heo <tj@...nel.org> To: Stephen Warren <swarren@...dotorg.org> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>, Mikko Perttunen <mperttunen@...dia.com>, thierry.reding@...il.com, pdeschrijver@...dia.com, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org, linux-ide@...r.kernel.org Subject: Re: [PATCH 8/9] ata: Add support for the Tegra124 SATA controller On Tue, Jun 17, 2014 at 12:13:20PM -0400, Tejun Heo wrote: > On Tue, Jun 17, 2014 at 10:10:23AM -0600, Stephen Warren wrote: > > > sata_writel() and sata_read() static inlines don't seem to add any value. > > > > > > Can they be removed? > > > > Such functions are quite idiomatic in drivers, and serve to simplify all > > the call-sites by removing the need to write out the addition of the > > base address everywhere. > > I think it obfuscates more than helps. If you absoluately have to > keep it, please at least name it so that it's clear that it's > something specific to this driver. Please also drop inline. It isn't a difficult optimization to perform for the compiler. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists