linux-kernel - Re: [PATCH v6 7/8] staging: lustre: lclient: lcommon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CFC5C64E.ABDAF%andreas.dilger@intel.com>
Date:	Tue, 17 Jun 2014 16:23:01 +0000
From:	"Dilger, Andreas" <andreas.dilger@...el.com>
To:	Anil Belur <askb23@...il.com>,
	"Drokin, Oleg" <oleg.drokin@...el.com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"hpdd-discuss@...ts.01.org" <hpdd-discuss@...ts.01.org>
Subject: Re: [PATCH v6 7/8] staging: lustre: lclient: lcommon_cl.c fixing
 coding style issues

On 2014/06/16, 11:43 PM, "Anil Belur" <askb23@...il.com> wrote:

>From: Anil Belur <askb23@...il.com>
>
>fixed: WARNING: line over 80 characters, used a new variable 'size_index'
>to
>store the offset. Replaceed "unsigned long" with  "loff_t" type for
>'cur_index'
>
>Signed-off-by: Anil Belur <askb23@...il.com>
>---
> drivers/staging/lustre/lustre/lclient/lcommon_cl.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/staging/lustre/lustre/lclient/lcommon_cl.c
>b/drivers/staging/lustre/lustre/lclient/lcommon_cl.c
>index 2f51b76..e2da397 100644
>--- a/drivers/staging/lustre/lustre/lclient/lcommon_cl.c
>+++ b/drivers/staging/lustre/lustre/lclient/lcommon_cl.c
>@@ -821,10 +821,11 @@ int ccc_prep_size(const struct lu_env *env, struct
>cl_object *obj,
> 				 * linux-2.6.18-128.1.1 miss to do that.
> 				 * --bug 17336 */
> 				loff_t size = cl_isize_read(inode);
>-				unsigned long cur_index = start >> PAGE_CACHE_SHIFT;
>+				loff_t cur_index = start >> PAGE_CACHE_SHIFT;
>+				loff_t size_index = ((size - 1) >> PAGE_CACHE_SHIFT);

Should be an empty line between variable declarations and code.

> 
> 				if ((size == 0 && cur_index != 0) ||
>-				    (((size - 1) >> PAGE_CACHE_SHIFT) < cur_index))
>+				    (size_index < cur_index))
> 				*exceed = 1;
> 			}
> 			return result;
>-- 
>1.9.0
>
>


Cheers, Andreas
-- 
Andreas Dilger

Lustre Software Architect
Intel High Performance Data Division


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/