[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <6FD758BB-2803-41BC-BFBF-2A607A68EAFA@intel.com>
Date: Tue, 17 Jun 2014 02:08:50 +0000
From: "Drokin, Oleg" <oleg.drokin@...el.com>
To: Anil Belur <askb23@...il.com>
CC: "Dilger, Andreas" <andreas.dilger@...el.com>,
"<tao.peng@....com>" <tao.peng@....com>,
"<gregkh@...uxfoundation.org>" <gregkh@...uxfoundation.org>,
"<linux-kernel@...r.kernel.org>" <linux-kernel@...r.kernel.org>,
"<hpdd-discuss@...ts.01.org>" <hpdd-discuss@...ts.01.org>
Subject: Re: [PATCH v5 7/8] staging: lustre: lclient: lcommon_cl.c fixing
coding style issues
On Jun 16, 2014, at 12:22 PM, Anil Belur wrote:
> From: Anil Belur <askb23@...il.com>
>
> fixed: WARNING: line over 80 characters, used a new variable 'size_index' to
> store the offset. Replace "unsigned long" with "u64" type for
Apparently you forgot to update the comment.
> 'cur_index'
>
> Signed-off-by: Anil Belur <askb23@...il.com>
> ---
> drivers/staging/lustre/lustre/lclient/lcommon_cl.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/lustre/lustre/lclient/lcommon_cl.c b/drivers/staging/lustre/lustre/lclient/lcommon_cl.c
> index c180a20..6c5b828 100644
> --- a/drivers/staging/lustre/lustre/lclient/lcommon_cl.c
> +++ b/drivers/staging/lustre/lustre/lclient/lcommon_cl.c
> @@ -864,10 +864,11 @@ int ccc_prep_size(const struct lu_env *env, struct cl_object *obj,
> * linux-2.6.18-128.1.1 miss to do that.
> * --bug 17336 */
> loff_t size = cl_isize_read(inode);
> - unsigned long cur_index = start >> PAGE_CACHE_SHIFT;
> + loff_t cur_index = start >> PAGE_CACHE_SHIFT;
> + loff_t size_index = ((size - 1) >> PAGE_CACHE_SHIFT);
>
> if ((size == 0 && cur_index != 0) ||
> - (((size - 1) >> PAGE_CACHE_SHIFT) < cur_index))
> + (size_index < cur_index))
> *exceed = 1;
> }
> return result;
> --
> 1.9.0
>
Bye,
Oleg--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists