linux-kernel - Re: [PATCH 6/9] mfd: palmas: shift the palmas_sleep_requestor_info structure definition to the header file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140617163339.GQ29841@lee--X1>
Date:	Tue, 17 Jun 2014 17:33:39 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Keerthy <j-keerthy@...com>
Cc:	linux-omap@...r.kernel.org, lgirdwood@...il.com,
	broonie@...nel.org, linux-kernel@...r.kernel.org,
	sameo@...ux.intel.com
Subject: Re: [PATCH 6/9] mfd: palmas: shift the palmas_sleep_requestor_info
 structure definition to the header file

On Wed, 28 May 2014, Keerthy wrote:

> shift the palmas_sleep_requestor_info structure definition to the header file.
> 
> Signed-off-by: Keerthy <j-keerthy@...com>
> ---
>  drivers/mfd/palmas.c       |   10 ----------
>  include/linux/mfd/palmas.h |   10 ++++++++++
>  2 files changed, 10 insertions(+), 10 deletions(-)

Acked-by: Lee Jones <lee.jones@...aro.org>

> diff --git a/drivers/mfd/palmas.c b/drivers/mfd/palmas.c
> index 485d755..f1f31d5 100644
> --- a/drivers/mfd/palmas.c
> +++ b/drivers/mfd/palmas.c
> @@ -25,16 +25,6 @@
>  #include <linux/mfd/palmas.h>
>  #include <linux/of_device.h>
>  
> -#define PALMAS_EXT_REQ (PALMAS_EXT_CONTROL_ENABLE1 |	\
> -			PALMAS_EXT_CONTROL_ENABLE2 |	\
> -			PALMAS_EXT_CONTROL_NSLEEP)
> -
> -struct palmas_sleep_requestor_info {
> -	int id;
> -	int reg_offset;
> -	int bit_pos;
> -};
> -
>  #define EXTERNAL_REQUESTOR(_id, _offset, _pos)		\
>  	[PALMAS_EXTERNAL_REQSTR_ID_##_id] = {		\
>  		.id = PALMAS_EXTERNAL_REQSTR_ID_##_id,	\
> diff --git a/include/linux/mfd/palmas.h b/include/linux/mfd/palmas.h
> index 150a6314..8d68452 100644
> --- a/include/linux/mfd/palmas.h
> +++ b/include/linux/mfd/palmas.h
> @@ -88,6 +88,16 @@ struct palmas {
>  	u8 pwm_muxed;
>  };
>  
> +#define PALMAS_EXT_REQ (PALMAS_EXT_CONTROL_ENABLE1 |	\
> +			PALMAS_EXT_CONTROL_ENABLE2 |	\
> +			PALMAS_EXT_CONTROL_NSLEEP)
> +
> +struct palmas_sleep_requestor_info {
> +	int id;
> +	int reg_offset;
> +	int bit_pos;
> +};
> +
>  struct regs_info {
>  	char	*name;
>  	char	*sname;

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/