linux-kernel - Re: [PATCHv2] Check if skb_alloc returns Null in function fw_download

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 17 Jun 2014 13:18:51 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Nicholas Krause <xerofoify@...il.com>
Cc:	devel@...verdev.osuosl.org, ben@...adent.org.uk,
	lisa@...apiadmin.com, valentina.manea.m@...il.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCHv2] Check if skb_alloc returns Null in function
 fw_download_code

On Tue, Jun 17, 2014 at 12:07:12PM -0400, Nicholas Krause wrote:
> Signed-off-by: Nicholas Krause <xerofoify@...il.com>
> ---
>  drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
> index 1a95d1f..11e915e 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
> @@ -61,11 +61,13 @@ static bool fw_download_code(struct net_device *dev, u8 *code_virtual_address,
>  		}
>  
>  		skb  = dev_alloc_skb(frag_length + 4);
> +		if (!skb)
> +			return 0;
>  			memcpy((unsigned char *)(skb->cb), &dev, sizeof(dev));
>  			tcb_desc = (struct cb_desc *)(skb->cb + MAX_DEV_ADDR_SIZE);

Again, look at this code and tell me if it now looks correct after your
change...

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/