linux-kernel - Re: [PATCH 1/1] scripts/coccinelle/free: add conditional kfree test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1406172331001.2055@localhost6.localdomain6>
Date:	Tue, 17 Jun 2014 23:33:00 +0200 (CEST)
From:	Julia Lawall <julia.lawall@...6.fr>
To:	Joe Perches <joe@...ches.com>
cc:	Fabian Frederick <fabf@...net.be>, linux-kernel@...r.kernel.org,
	Gilles Muller <Gilles.Muller@...6.fr>
Subject: Re: [PATCH 1/1] scripts/coccinelle/free: add conditional kfree
 test



On Tue, 17 Jun 2014, Joe Perches wrote:

> On Tue, 2014-06-17 at 21:43 +0200, Fabian Frederick wrote:
> > This patch adds a trivial script warning on
> > 
> > if(foo)
> > 	kfree(foo)
> > 
> > (based on checkpatch)
> []
> > diff --git a/scripts/coccinelle/free/cond_kfree.cocci b/scripts/coccinelle/free/cond_kfree.cocci
> []
> > +* if (E)
> > +*	kfree@p(E);
> 
> You should probably add all of the unnecessary
> conditional tests that checkpatch uses:
> 
> kfree
> usb_free_urb
> debugfs_remove
> debugfs_remove_recursive

Personally, I would prefer that the message encourage the user to consider 
whether it is necessary to call these functions with NULL as an argument 
in any case.

julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/