linux-kernel - Re: [PATCHv2] Fixes function fw_download_code to check for Null return from dev_skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140617215709.GA20496@kroah.com>
Date:	Tue, 17 Jun 2014 14:57:09 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Nicholas Krause <xerofoify@...il.com>
Cc:	devel@...verdev.osuosl.org, lisa@...apiadmin.com,
	ben@...adent.org.uk, valentina.manea.m@...il.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCHv2] Fixes function fw_download_code to check for Null
 return from dev_skb_alloc

Lots of things wrong here, please step back, and slow down.

Your subject, this really isn't "v2", is it?

On Tue, Jun 17, 2014 at 05:18:01PM -0400, Nicholas Krause wrote:
> Signed-off-by: Nicholas Krause <xerofoify@...il.com>

You aren't saying what you are doing here in the body of the patch, why
not?

> ---
>  drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
> index 11e915e..e4c8224 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
> @@ -62,12 +62,14 @@ static bool fw_download_code(struct net_device *dev, u8 *code_virtual_address,
>  
>  		skb  = dev_alloc_skb(frag_length + 4);
>  		if (!skb){
> +			rt_status = false;
> +			return rt_status;
> +		}

Again, this patch will not apply to the tree, you are making it against
your previous patch, which was rejected.  There is no way I can take
this, right?

Please start over and try again from a "clean" kernel tree.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/