linux-kernel - Re: [PATCH 7/9] regulator: palmas: Add palmas_pmic_driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140618072436.GA21030@lee--X1>
Date:	Wed, 18 Jun 2014 08:24:36 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Keerthy <a0393675@...com>
Cc:	Keerthy <j-keerthy@...com>, linux-omap@...r.kernel.org,
	lgirdwood@...il.com, broonie@...nel.org,
	linux-kernel@...r.kernel.org, sameo@...ux.intel.com
Subject: Re: [PATCH 7/9] regulator: palmas: Add palmas_pmic_driver_data
 structure

> >>Add palmas_pmic_driver_data structure.
> >>
> >>Signed-off-by: Keerthy <j-keerthy@...com>
> >>---
> >>  include/linux/mfd/palmas.h |   25 +++++++++++++++++++++++++
> >>  1 file changed, 25 insertions(+)
> >>
> >>diff --git a/include/linux/mfd/palmas.h b/include/linux/mfd/palmas.h
> >>index 8d68452..70f0695 100644
> >>--- a/include/linux/mfd/palmas.h
> >>+++ b/include/linux/mfd/palmas.h
[...]

> >>+struct palmas_pmic_driver_data {
> >>+	int smps_start;
> >>+	int smps_end;
> >>+	int ldo_begin;
> >>+	int ldo_end;
> >>+	int max_reg;
> >>+	struct regs_info *palmas_regs_info;
> >>+	struct of_regulator_match *palmas_matches;
> >>+	struct palmas_sleep_requestor_info *sleep_req_info;
> >>+	int (*smps_register)(struct palmas_pmic *pmic,
> >>+			     struct palmas_pmic_driver_data *ddata,
> >>+			     struct palmas_pmic_platform_data *pdata,
> >>+			     const char *pdev_name,
> >>+			     struct regulator_config config);
> >>+	int (*ldo_register)(struct palmas_pmic *pmic,
> >>+			    struct palmas_pmic_driver_data *ddata,
> >>+			    struct palmas_pmic_platform_data *pdata,
> >>+			    const char *pdev_name,
> >>+			    struct regulator_config config);
> >Are you sure you need to store all of this stuff?
> >
> >Particularly the match pointer.  Do you really re-use it?
> 
> Match pointer is used extensively in the palmas_regulator.c.
> This structure is very much used by regulator driver.

On closer inspection, I now see that it's a 'of_regulator_match',
rather than an 'of_match' pointer, which were my initial thoughts.  I
think it would have been weird to carry the 'of_match', but the
reality sounds sane.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/