| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <53A17A09.6010007@redhat.com>
Date: Wed, 18 Jun 2014 13:37:45 +0200
From: Paolo Bonzini <pbonzini@...hat.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
Peter Zijlstra <a.p.zijlstra@...llo.nl>
CC: Waiman.Long@...com, tglx@...utronix.de, mingo@...nel.org,
linux-arch@...r.kernel.org, linux-kernel@...r.kernel.org,
virtualization@...ts.linux-foundation.org,
xen-devel@...ts.xenproject.org, kvm@...r.kernel.org,
paolo.bonzini@...il.com, boris.ostrovsky@...cle.com,
paulmck@...ux.vnet.ibm.com, riel@...hat.com,
torvalds@...ux-foundation.org, raghavendra.kt@...ux.vnet.ibm.com,
david.vrabel@...rix.com, oleg@...hat.com, gleb@...hat.com,
scott.norton@...com, chegu_vinod@...com,
Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH 04/11] qspinlock: Extract out the exchange of tail code
word
Il 17/06/2014 22:55, Konrad Rzeszutek Wilk ha scritto:
> On Sun, Jun 15, 2014 at 02:47:01PM +0200, Peter Zijlstra wrote:
>> From: Waiman Long <Waiman.Long@...com>
>>
>> This patch extracts the logic for the exchange of new and previous tail
>> code words into a new xchg_tail() function which can be optimized in a
>> later patch.
>
> And also adds a third try on acquiring the lock. That I think should
> be a seperate patch.
It doesn't really add a new try, the old code is:
- for (;;) {
- new = _Q_LOCKED_VAL;
- if (val)
- new = tail | (val & _Q_LOCKED_PENDING_MASK);
-
- old = atomic_cmpxchg(&lock->val, val, new);
- if (old == val)
- break;
-
- val = old;
- }
/*
- * we won the trylock; forget about queueing.
*/
- if (new == _Q_LOCKED_VAL)
- goto release;
The trylock happens if the "if (val)" hits the else branch.
What the patch does is change it from attempting two transition with a
single cmpxchg:
- * 0,0,0 -> 0,0,1 ; trylock
- * p,y,x -> n,y,x ; prev = xchg(lock, node)
to first doing the trylock, then the xchg. If the trylock passes and
the xchg returns prev=0,0,0, the next step of the algorithm goes to the
locked/uncontended state
+ /*
+ * claim the lock:
+ *
+ * n,0 -> 0,1 : lock, uncontended
Similar to your suggestion of patch 3, it's expected that the xchg will
*not* return prev=0,0,0 after a failed trylock.
However, I *do* agree with you that it's simpler to just squash this
patch into 01/11.
Paolo
> And instead of saying 'later patch' you should spell out the name
> of the patch. Especially as this might not be obvious from somebody
> doing git bisection.
>
>>
>> Signed-off-by: Waiman Long <Waiman.Long@...com>
>> Signed-off-by: Peter Zijlstra <peterz@...radead.org>
>> ---
>> include/asm-generic/qspinlock_types.h | 2 +
>> kernel/locking/qspinlock.c | 58 +++++++++++++++++++++-------------
>> 2 files changed, 38 insertions(+), 22 deletions(-)
>>
>> --- a/include/asm-generic/qspinlock_types.h
>> +++ b/include/asm-generic/qspinlock_types.h
>> @@ -61,6 +61,8 @@ typedef struct qspinlock {
>> #define _Q_TAIL_CPU_BITS (32 - _Q_TAIL_CPU_OFFSET)
>> #define _Q_TAIL_CPU_MASK _Q_SET_MASK(TAIL_CPU)
>>
>> +#define _Q_TAIL_MASK (_Q_TAIL_IDX_MASK | _Q_TAIL_CPU_MASK)
>> +
>> #define _Q_LOCKED_VAL (1U << _Q_LOCKED_OFFSET)
>> #define _Q_PENDING_VAL (1U << _Q_PENDING_OFFSET)
>>
>> --- a/kernel/locking/qspinlock.c
>> +++ b/kernel/locking/qspinlock.c
>> @@ -86,6 +86,31 @@ static inline struct mcs_spinlock *decod
>> #define _Q_LOCKED_PENDING_MASK (_Q_LOCKED_MASK | _Q_PENDING_MASK)
>>
>> /**
>> + * xchg_tail - Put in the new queue tail code word & retrieve previous one
>> + * @lock : Pointer to queue spinlock structure
>> + * @tail : The new queue tail code word
>> + * Return: The previous queue tail code word
>> + *
>> + * xchg(lock, tail)
>> + *
>> + * p,*,* -> n,*,* ; prev = xchg(lock, node)
>> + */
>> +static __always_inline u32 xchg_tail(struct qspinlock *lock, u32 tail)
>> +{
>> + u32 old, new, val = atomic_read(&lock->val);
>> +
>> + for (;;) {
>> + new = (val & _Q_LOCKED_PENDING_MASK) | tail;
>> + old = atomic_cmpxchg(&lock->val, val, new);
>> + if (old == val)
>> + break;
>> +
>> + val = old;
>> + }
>> + return old;
>> +}
>> +
>> +/**
>> * queue_spin_lock_slowpath - acquire the queue spinlock
>> * @lock: Pointer to queue spinlock structure
>> * @val: Current value of the queue spinlock 32-bit word
>> @@ -182,36 +207,25 @@ void queue_spin_lock_slowpath(struct qsp
>> node->next = NULL;
>>
>> /*
>> - * we already touched the queueing cacheline; don't bother with pending
>> - * stuff.
>> - *
>> - * trylock || xchg(lock, node)
>> - *
>> - * 0,0,0 -> 0,0,1 ; trylock
>> - * p,y,x -> n,y,x ; prev = xchg(lock, node)
>> + * We touched a (possibly) cold cacheline in the per-cpu queue node;
>> + * attempt the trylock once more in the hope someone let go while we
>> + * weren't watching.
>> */
>> - for (;;) {
>> - new = _Q_LOCKED_VAL;
>> - if (val)
>> - new = tail | (val & _Q_LOCKED_PENDING_MASK);
>> -
>> - old = atomic_cmpxchg(&lock->val, val, new);
>> - if (old == val)
>> - break;
>> -
>> - val = old;
>> - }
>> + if (queue_spin_trylock(lock))
>> + goto release;
>
> So now are three of them? One in queue_spin_lock, then at the start
> of this function when checking for the pending bit, and the once more
> here. And that is because the local cache line might be cold for the
> 'mcs_index' struct?
>
> That all seems to be a bit of experimental. But then we are already
> in the slowpath so we could as well do:
>
> for (i = 0; i < 10; i++)
> if (queue_spin_trylock(lock))
> goto release;
>
> And would have the same effect.
>
>
>>
>> /*
>> - * we won the trylock; forget about queueing.
>> + * we already touched the queueing cacheline; don't bother with pending
>> + * stuff.
>
> I guess we could also just erase the pending bit if we wanted too. The
> optimistic spinning will still hit go to the queue label as lock->val will
> have the tail value.
>
>> + *
>> + * p,*,* -> n,*,*
>> */
>> - if (new == _Q_LOCKED_VAL)
>> - goto release;
>> + old = xchg_tail(lock, tail);
>>
>> /*
>> * if there was a previous node; link it and wait.
>> */
>> - if (old & ~_Q_LOCKED_PENDING_MASK) {
>> + if (old & _Q_TAIL_MASK) {
>> prev = decode_tail(old);
>> ACCESS_ONCE(prev->next) = node;
>>
>>
>>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists