| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20140618135618.GI24049@console-pimps.org> Date: Wed, 18 Jun 2014 14:56:18 +0100 From: Matt Fleming <matt@...sole-pimps.org> To: Daniel Kiper <daniel.kiper@...cle.com> Cc: linux-efi@...r.kernel.org, linux-kernel@...r.kernel.org, x86@...nel.org, xen-devel@...ts.xenproject.org, andrew.cooper3@...rix.com, boris.ostrovsky@...cle.com, david.vrabel@...rix.com, eshelton@...ox.com, hpa@...or.com, ian.campbell@...rix.com, jbeulich@...e.com, jeremy@...p.org, konrad.wilk@...cle.com, matt.fleming@...el.com, mingo@...hat.com, mjg59@...f.ucam.org, stefano.stabellini@...citrix.com, tglx@...utronix.de Subject: Re: [PATCH v5 5/7] arch/x86: Replace plain strings with constants On Fri, 13 Jun, at 07:00:21PM, Daniel Kiper wrote: > v5 - suggestions/fixes: > - do not change indentation > (suggested by Matt Fleming). > > Signed-off-by: Daniel Kiper <daniel.kiper@...cle.com> > --- > arch/x86/kernel/setup.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Looks good, but it's customary to have at least one line after the patch title. Even something as trivial as, "We've got constants, so let's use them instead of hard-coded values." -- Matt Fleming, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists