linux-kernel - Re: [PATCH v6 03/10] x86, mpx: add macro cpu_has

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140618152505.GE24024@pd.tnic>
Date:	Wed, 18 Jun 2014 17:25:05 +0200
From:	Borislav Petkov <bp@...en8.de>
To:	Dave Hansen <dave.hansen@...el.com>
Cc:	Qiaowei Ren <qiaowei.ren@...el.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>, x86@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 03/10] x86, mpx: add macro cpu_has_mpx

On Wed, Jun 18, 2014 at 07:58:21AM -0700, Dave Hansen wrote:
> Are you seriously asking why we would want to cull out code guaranteed
> to be unused?

Yes, I am. Don't get me wrong - I'm all for not enabling code which is
unused - I'm just questioning the actual usage case here.

Because you have this:

+config X86_INTEL_MPX
+       def_bool y
+       depends on CPU_SUP_INTEL

which means, even on !MPX Intels, you need to explicitly say "no" here.
Is this how the configuration is supposed to be done?

Or do you need to add help text to explain to people not to enable this
on !MPX machines after looking at /proc/cpuinfo first?

Am I close?

> The minuscule number of people not using a distro kernel?  Like, every
> Android and Chrome device in the world?  How about the cloud providers
> with millions of servers?

Cloud people won't be benefiting from MPX?

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/