linux-kernel - Re: [PATCH 1/2] regulators: TPS65218: Add the missing of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53A1B58C.6070508@ti.com>
Date:	Wed, 18 Jun 2014 10:51:40 -0500
From:	Nishanth Menon <nm@...com>
To:	Felipe Balbi <balbi@...com>, <lgirdwood@...il.com>,
	<broonie@...nel.org>
CC:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linux OMAP Mailing List <linux-omap@...r.kernel.org>,
	Linux ARM Kernel Mailing List 
	<linux-arm-kernel@...ts.infradead.org>, Keerthy <j-keerthy@...com>,
	<stable@...r.kernel.org>
Subject: Re: [PATCH 1/2] regulators: TPS65218: Add the missing of_node assignment
 in probe

nit pick:
s/regulators: TPS65218:/regulators: tps65218:/

On 06/18/2014 10:17 AM, Felipe Balbi wrote:
> From: Keerthy <j-keerthy@...com>
> 
> Add the missing of_node assignment in probe.
Hmm... I think an explanation of the type below might be nice:

config.of_node is used to populate the regulator_dev->dev.of_node as
part of registration. this is used for consumer supply match to the
right regulator device such as in regulator_dev_lookup.

not populating config.of_node results in inability to use the
regulator node as a supply in device tree.


> 
> Cc: <stable@...r.kernel.org> # v3.15

Fixes: 90e7d5262796 (regulator: tps65218: Add Regulator driver for
TPS65218 PMIC)

?
> Signed-off-by: Keerthy <j-keerthy@...com>
> Signed-off-by: Felipe Balbi <balbi@...com>
> ---
>  drivers/regulator/tps65218-regulator.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/regulator/tps65218-regulator.c b/drivers/regulator/tps65218-regulator.c
> index 69b4b77..edbc46e 100644
> --- a/drivers/regulator/tps65218-regulator.c
> +++ b/drivers/regulator/tps65218-regulator.c
> @@ -240,6 +240,7 @@ static int tps65218_regulator_probe(struct platform_device *pdev)
>  	config.init_data = init_data;
>  	config.driver_data = tps;
>  	config.regmap = tps->regmap;
> +	config.of_node = pdev->dev.of_node;
>  
>  	rdev = devm_regulator_register(&pdev->dev, &regulators[id], &config);
>  	if (IS_ERR(rdev)) {
> 

otherwise,
Acked-by: Nishanth Menon <nm@...com>
-- 
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/