linux-kernel - Re: [PATCH] arm64: support reboot and power off via EFI runtime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140618155356.GR24049@console-pimps.org>
Date:	Wed, 18 Jun 2014 16:53:56 +0100
From:	Matt Fleming <matt@...sole-pimps.org>
To:	Mark Salter <msalter@...hat.com>
Cc:	Rob Herring <robherring2@...il.com>,
	Catalin Marinas <catalin.marinas@....com>,
	Will Deacon <will.deacon@....com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>, linux-efi@...r.kernel.org
Subject: Re: [PATCH] arm64: support reboot and power off via EFI runtime

On Wed, 18 Jun, at 10:41:47AM, Mark Salter wrote:
> On Wed, 2014-06-18 at 09:09 -0500, Rob Herring wrote:
> > On Tue, Jun 17, 2014 at 11:45 AM, Mark Salter <msalter@...hat.com> wrote:
> > > Add handlers for arm_pm_resestart and pm_power_off which use EFI
> > 
> > typo.
> > 
> > > runtime services ResetSystem call to perform the functions. These
> > > handlers are only installed if no handler currently exists. This
> > > allows PSCI to take priority over EFI for these functions.
> > >
> > > Signed-off-by: Mark Salter <msalter@...hat.com>
> > > ---
> > >  arch/arm64/kernel/efi.c | 40 ++++++++++++++++++++++++++++++++++++++++
> > 
> > Where's the arm32 version? Surely this could be shared with all
> > arches. pm_power_off is at least architecturally independent. We
> > should do the same for restart/reboot. I'm not saying do that now, but
> > at least put it in the right place for that to happen.
> > 
> > Rob
> 
> Good point. So the right place would be drivers/firmware/efi I think.
> Add a CONFIG_EFI_RESET with default off. I suppose we could also
> go ahead and s/arm_pm_restart/pm_restart/ kernel-wide or have an
> ifdef in the code (or depends on ARM64 || ARM in Kconfig) until we
> do so.
> 
> [Matt Fleming CC'd]
 
Heh, this is timely. I wrote some patches last week to use
EfiResetSystem() for ACPI Hardware Reduced platforms,

  http://git.kernel.org/cgit/linux/kernel/git/mfleming/efi.git/log/?h=efi/reboot

so it would definitely be good if we could try and solve both of our
problems simultaneously.

Let me post that patch series to kickoff the discussion.

-- 
Matt Fleming, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/