linux-kernel - Re: relative objtree change broke tar builds?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53A1B72E.7030907@infradead.org>
Date:	Wed, 18 Jun 2014 08:58:38 -0700
From:	Randy Dunlap <rdunlap@...radead.org>
To:	"J. Bruce Fields" <bfields@...ldses.org>,
	Michal Marek <mmarek@...e.cz>
CC:	linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: relative objtree change broke tar builds?

On 06/18/14 06:14, J. Bruce Fields wrote:
> On Wed, Jun 18, 2014 at 02:33:22PM +0200, Michal Marek wrote:
>> Dne 18.6.2014 14:20, J. Bruce Fields napsal(a):
>>> On Wed, Jun 18, 2014 at 11:06:12AM +0200, Michal Marek wrote:
>>>> Dne 18.6.2014 00:38, J. Bruce Fields napsal(a):
>>>>> The changelog there says
>>>>>
>>>>> 	The main Makefile sets its working directory to the object tree
>>>>> 	and never changes it again. Therefore, we can use '.' instead of
>>>>> 	the absolute path.
>>>>>
>>>>> But the main Makefile also exports objtree, and a quick grep suggests
>>>>> lots of other uses outside the main Makefile.
>>>>
>>>> Do you have examples? Besides your report, I'm only aware of make
>>>> deb-pkg and make *docs. What else?
>>>
>>> I haven't looked.
>>>
>>> I only note that grep finds 47 files referencing that variable, and
>>> absent some argument that the remaining ones are correct, I'd be
>>> inclined to revert.
>>
>> Do these 47 files change the working directory before referencing the
>> variable?
> 
> Sorry, I'm not volunteering to check.
> 
> Note also that other variables are defined in terms of objtree, and they
> may be exported or passed to other scripts.


I'll note one side effect that I really dislike:
If not in silent mode, scripts/mkmakefile tells me that the it is
generating ./Makefile.  I want to see the real path there instead of '.'.


-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/