lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 17 Jun 2014 20:35:56 -0700 From: Simon Glass <sjg@...omium.org> To: Doug Anderson <dianders@...omium.org> Cc: Lee Jones <lee.jones@...aro.org>, Andrew Bresticker <abrestic@...omium.org>, Stephen Warren <swarren@...dotorg.org>, Olof Johansson <olof@...om.net>, Sonny Rao <sonnyrao@...omium.org>, linux-samsung-soc <linux-samsung-soc@...r.kernel.org>, Javier Martinez Canillas <javier.martinez@...labora.co.uk>, Bill Richardson <wfrichar@...omium.org>, Wolfram Sang <wsa@...-dreams.de>, Mark Brown <broonie@...nel.org>, Samuel Ortiz <sameo@...ux.intel.com>, lk <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 04/10] mfd: cros_ec: Tweak struct cros_ec_device for clarity Hi Doug, On 16 June 2014 14:39, Doug Anderson <dianders@...omium.org> wrote: > From: Bill Richardson <wfrichar@...omium.org> > > The members of struct cros_ec_device were improperly commented, and > intermixed the private and public sections. This is just cleanup to make it > more obvious what goes with what. > > [dianders: left lock in the structure but gave it the name that will > eventually be used.] > > Signed-off-by: Bill Richardson <wfrichar@...omium.org> > Signed-off-by: Doug Anderson <dianders@...omium.org> > --- > drivers/mfd/cros_ec.c | 2 +- > drivers/mfd/cros_ec_i2c.c | 4 +-- > drivers/mfd/cros_ec_spi.c | 10 +++---- > include/linux/mfd/cros_ec.h | 65 ++++++++++++++++++++++++--------------------- > 4 files changed, 43 insertions(+), 38 deletions(-) > > diff --git a/drivers/mfd/cros_ec.c b/drivers/mfd/cros_ec.c > index bd6f936..a9eede5 100644 > --- a/drivers/mfd/cros_ec.c > +++ b/drivers/mfd/cros_ec.c > @@ -57,7 +57,7 @@ static int cros_ec_command_sendrecv(struct cros_ec_device *ec_dev, > msg.in_buf = in_buf; > msg.in_len = in_len; > > - return ec_dev->command_xfer(ec_dev, &msg); > + return ec_dev->cmd_xfer(ec_dev, &msg); Why do this rename? It makes it different from the other members. Regards, Simon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists