linux-kernel - Re: [PATCH 1/1] security: Used macros from compiler.h instead of __attribute_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3604441.fZpjWNppGq@sifl>
Date:	Wed, 18 Jun 2014 14:50:44 -0400
From:	Paul Moore <paul@...l-moore.com>
To:	Gideon Israel Dsouza <gidisrael@...il.com>
Cc:	sds@...ho.nsa.gov, eparis@...isplace.org,
	akpm@...ux-foundation.org, geert@...ux-m68k.org,
	linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] security: Used macros from compiler.h instead of __attribute__((...))

On Wednesday, June 11, 2014 09:25:30 PM Gideon Israel Dsouza wrote:
> To increase compiler portability there is <linux/compiler.h> which
> provides convenience macros for various gcc constructs.  Eg: __packed
> for __attribute__((packed)).
> 
> This patch is part of a large task I've taken to clean the gcc
> specific attributes and use the the macros instead.
> 
> Signed-off-by: Gideon Israel Dsouza <gidisrael@...il.com>
> ---
>  security/selinux/include/security.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

>From what I can tell this should still work with both the LLVM and Intel 
compilers, is that correct?

> diff --git a/security/selinux/include/security.h
> b/security/selinux/include/security.h index ce7852c..ff19bcc 100644
> --- a/security/selinux/include/security.h
> +++ b/security/selinux/include/security.h
> @@ -8,6 +8,7 @@
>  #ifndef _SELINUX_SECURITY_H_
>  #define _SELINUX_SECURITY_H_
> 
> +#include <linux/compiler.h>
>  #include <linux/dcache.h>
>  #include <linux/magic.h>
>  #include <linux/types.h>
> @@ -220,7 +221,7 @@ struct selinux_kernel_status {
>  	/*
>  	 * The version > 0 supports above members.
>  	 */
> -} __attribute__((packed));
> +} __packed;
> 
>  extern void selinux_status_update_setenforce(int enforcing);
>  extern void selinux_status_update_policyload(int seqno);

-- 
paul moore
www.paul-moore.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/