linux-kernel - Re: [PATCH] ns: introduce getnspid syscall

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 18 Jun 2014 23:10:23 +0400
From:	Pavel Emelyanov <xemul@...allels.com>
To:	Oleg Nesterov <oleg@...hat.com>
CC:	Chen Hanxiao <chenhanxiao@...fujitsu.com>,
	<containers@...ts.linux-foundation.org>,
	<linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Serge Hallyn <serge.hallyn@...ntu.com>,
	"Daniel P. Berrange" <berrange@...hat.com>,
	Al Viro <viro@...iv.linux.org.uk>,
	"David Howells" <dhowells@...hat.com>,
	Richard Weinberger <richard.weinberger@...il.com>,
	Vasiliy Kulikov <segooon@...il.com>,
	"Gotou Yasunori" <y-goto@...fujitsu.com>
Subject: Re: [PATCH] ns: introduce getnspid syscall

On 06/18/2014 10:02 PM, Oleg Nesterov wrote:
> On 06/17, Pavel Emelyanov wrote:
>>
>> On 06/17/2014 02:21 PM, Chen Hanxiao wrote:
>>> +	case PIDTYPE_PID:
>>> +		ret = task_pid_nr_ns(task, ns2);
>>
>> But this is not correct. If task doesn't live in ns2, but ns2
>> just has the ns->level small enough, then the wrong pid value
>> would be reported.
> 
> Confused... pid_nr_ns() checks upid->ns == ns and returns zero
> otherwise?

Yes, you're right. I've missed that line of code :(

> Oleg.
> 
> .
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/