linux-kernel - Re: [PATCH v2 1/2] arm: dts: am4372: let boards enable RTC and Watchdog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140618192553.GB4570@saruman.home>
Date:	Wed, 18 Jun 2014 14:25:53 -0500
From:	Felipe Balbi <balbi@...com>
To:	Nishanth Menon <nm@...com>
CC:	Felipe Balbi <balbi@...com>,
	Benoit Cousson <bcousson@...libre.com>, <robh+dt@...nel.org>,
	<galak@...eaurora.org>, Tony Lindgren <tony@...mide.com>,
	<linux@....linux.org.uk>, Rajendra Nayak <rnayak@...com>,
	<r.sricharan@...com>, <devicetree@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linux ARM Kernel Mailing List 
	<linux-arm-kernel@...ts.infradead.org>,
	Linux OMAP Mailing List <linux-omap@...r.kernel.org>
Subject: Re: [PATCH v2 1/2] arm: dts: am4372: let boards enable RTC and
 Watchdog

Hi,

On Wed, Jun 18, 2014 at 10:55:35AM -0500, Nishanth Menon wrote:
> $subject - ARM: dts:
> 
> On 06/18/2014 10:43 AM, Felipe Balbi wrote:
> > by providing phandles to rtc and wdt nodes, we can
> > let boards enable rtc and wdt as necessary.
> > 
> > Signed-off-by: Felipe Balbi <balbi@...com>
> > ---
> >  arch/arm/boot/dts/am4372.dtsi | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi
> > index 49fa596..e3830d4 100644
> > --- a/arch/arm/boot/dts/am4372.dtsi
> > +++ b/arch/arm/boot/dts/am4372.dtsi
> > @@ -270,7 +270,7 @@
> >  			ti,hwmods = "counter_32k";
> >  		};
> >  
> > -		rtc@...3e000 {
> > +		rtc: rtc@...3e000 {
> >  			compatible = "ti,am4372-rtc","ti,da830-rtc";
> >  			reg = <0x44e3e000 0x1000>;
> >  			interrupts = <GIC_SPI 75 IRQ_TYPE_LEVEL_HIGH
> > @@ -279,7 +279,7 @@
> >  			status = "disabled";
> >  		};
> >  
> > -		wdt@...35000 {
> > +		wdt: wdt@...35000 {
> >  			compatible = "ti,am4372-wdt","ti,omap3-wdt";
> >  			reg = <0x44e35000 0x1000>;
> >  			interrupts = <GIC_SPI 91 IRQ_TYPE_LEVEL_HIGH>;
> > 
> we might want to fix up any other similar nodes in dtsi as well, no?
>
> examples:
> cpu@0

and why would you want boards to mess with the cpu node ?

> dispc@...2a400

perhaps

> Might also be nice to have Fixes: to point out which commit was being
> fixed, no?

no other board enables those, so I wouldn't consider it a fix.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)