linux-kernel - Re: [PATCH] regulator: bcm590xx: fix vbus name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140618203234.GQ4173@beef>
Date:	Wed, 18 Jun 2014 16:32:34 -0400
From:	Matt Porter <mporter@...aro.org>
To:	Graham Williams <graham.williams@...aro.org>
Cc:	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>,
	Lee Jones <lee.jones@...aro.org>,
	Dave Jones <davej@...hat.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] regulator: bcm590xx: fix vbus name

On Wed, Jun 18, 2014 at 12:42:10PM -0700, Graham Williams wrote:
> The vbus regulator was not getting its name set. This results
> in the sysfs entry being empty. The lack of a bcm590xx_regs[]
> table entry also upsets Coverity runs. Add the table entry
> so the name gets set properly.
> 
> Signed-off-by: Graham Williams <graham.williams@...aro.org>
> ---
>  drivers/regulator/bcm590xx-regulator.c |    5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/regulator/bcm590xx-regulator.c b/drivers/regulator/bcm590xx-regulator.c
> index 57544e2..58ece59 100644
> --- a/drivers/regulator/bcm590xx-regulator.c
> +++ b/drivers/regulator/bcm590xx-regulator.c
> @@ -119,6 +119,10 @@ static const unsigned int ldo_c_table[] = {
>  	2900000, 3000000, 3300000,
>  };
>  
> +static const unsigned int ldo_vbus[] = {
> +	5000000,
> +};
> +
>  /* DCDC group CSR: supported voltages in microvolts */
>  static const struct regulator_linear_range dcdc_csr_ranges[] = {
>  	REGULATOR_LINEAR_RANGE(860000, 2, 50, 10000),
> @@ -192,6 +196,7 @@ static struct bcm590xx_info bcm590xx_regs[] = {
>  	BCM590XX_REG_TABLE(gpldo4, ldo_a_table),
>  	BCM590XX_REG_TABLE(gpldo5, ldo_a_table),
>  	BCM590XX_REG_TABLE(gpldo6, ldo_a_table),
> +	BCM590XX_REG_TABLE(vbus, ldo_vbus),
>  };

Also fixes the functional problem for me on the Capri board, thanks.
Coverity should also be much happier now.

Acked-by: Matt Porter <mporter@...aro.org>

Mark: can you pick this up for 3.16 fixes?

-Matt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/