linux-kernel - Re: [PATCH v3] ARM: fix debug prints relevant to PCI devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140618215637.GB26514@mithrandir>
Date:	Wed, 18 Jun 2014 23:56:38 +0200
From:	Thierry Reding <thierry.reding@...il.com>
To:	Vidya Sagar <vidyas@...dia.com>
Cc:	linux@....linux.org.uk, bhelgaas@...gle.com, wangyijing@...wei.com,
	jason@...edaemon.net, will.deacon@....com, swarren@...dia.com,
	kthota@...dia.com, sagar.tv@...il.com,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] ARM: fix debug prints relevant to PCI devices

On Wed, Jun 18, 2014 at 11:37:48PM +0530, Vidya Sagar wrote:
[...]
> diff --git a/arch/arm/kernel/bios32.c b/arch/arm/kernel/bios32.c
> index 17a26c1..fcf2581 100644
> --- a/arch/arm/kernel/bios32.c
> +++ b/arch/arm/kernel/bios32.c
> @@ -290,6 +290,7 @@ void pcibios_fixup_bus(struct pci_bus *bus)
>  {
>  	struct pci_dev *dev;
>  	u16 features = PCI_COMMAND_SERR | PCI_COMMAND_PARITY | PCI_COMMAND_FAST_BACK;
> +	bool has_pcie_dev = 0;

s/0/false/

> @@ -354,9 +357,11 @@ void pcibios_fixup_bus(struct pci_bus *bus)
>  
>  	/*
>  	 * Report what we did for this bus
> +	 * (only if the bus doesn't have even one PCIe device)

I find this hard to read. Perhaps "only if the bus doesn't have any PCIe
devices"?

>  	 */
> -	printk(KERN_INFO "PCI: bus%d: Fast back to back transfers %sabled\n",
> -		bus->number, (features & PCI_COMMAND_FAST_BACK) ? "en" : "dis");
> +	if (!has_pcie_dev)
> +		pr_info("PCI: bus%d: Fast back to back transfers %sabled\n",
> +			bus->number, (features & PCI_COMMAND_FAST_BACK) ? "en" : "dis");

I think this now makes checkpatch complain about this last line being
longer than 80 characters. But looking at checkpatch output on the
current version of the file there are already some lines that exceed the
limit as well, so maybe this can be ignored?

Thierry

Content of type "application/pgp-signature" skipped