lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 19 Jun 2014 11:29:28 +0400 From: Andrey Ryabinin <a.ryabinin@...sung.com> To: David Rientjes <rientjes@...gle.com> Cc: Andrew Morton <akpm@...ux-foundation.org>, Vladimir Davydov <vdavydov@...allels.com>, Pekka Enberg <penberg@...nel.org>, Christoph Lameter <cl@...ux.com>, linux-mm@...ck.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] mm: slab.h: wrap the whole file with guarding macro On 06/19/14 00:22, David Rientjes wrote: > On Wed, 18 Jun 2014, Andrey Ryabinin wrote: > >> Guarding section: >> #ifndef MM_SLAB_H >> #define MM_SLAB_H >> ... >> #endif >> currently doesn't cover the whole mm/slab.h. It seems like it was >> done unintentionally. >> >> Wrap the whole file by moving closing #endif to the end of it. >> >> Signed-off-by: Andrey Ryabinin <a.ryabinin@...sung.com> > > Acked-by: David Rientjes <rientjes@...gle.com> > > Looks like > > ca34956b804b ("slab: Common definition for kmem_cache_node") > e25839f67948 ("mm/slab: Sharing s_next and s_stop between slab and slub > 276a2439ce79 ("mm/slab: Give s_next and s_stop slab-specific names") > > added onto the header without the guard and it has been this way since > Jan 10 2013. Andrey, how did you notice that this was an issue? Simply > by visual inspection? > I had to do some modifications in this file for some reasons, and for me it was hard to not notice lack of endif in the end. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists