linux-kernel - Re: [PATCH] of: Check for phys_addr_t overflows in early_init_dt_add_memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdUaL19dN=p1pVw9PvNPRhzvtr+hLvoqASwPopXhdmUNhg@mail.gmail.com>
Date:	Thu, 19 Jun 2014 09:43:24 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Laura Abbott <lauraa@...eaurora.org>
Cc:	Grant Likely <grant.likely@...aro.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Simon Horman <horms@...ge.net.au>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Rob Herring <robherring2@...il.com>
Subject: Re: [PATCH] of: Check for phys_addr_t overflows in early_init_dt_add_memory_arch

Fixed Rob's and devicetree's addresses

On Thu, Jun 19, 2014 at 9:31 AM, Geert Uytterhoeven
<geert@...ux-m68k.org> wrote:
> Hi Laura,
>
> On Thu, Jun 19, 2014 at 7:04 AM, Laura Abbott <lauraa@...eaurora.org> wrote:
>> The common early_init_dt_add_memory_arch takes the base and size
>> of a memory region as u64 types. The function never checks if
>> the base and size can actually fit in a phys_addr_t which may
>> be smaller than 64-bits. This may result in incorrect memory
>> being passed to memblock_add if the memory falls outside the
>> range of phys_addr_t. Add range checks for the base and size if
>> phys_addr_t is smaller than u64.
>>
>> Reported-by: Geert Uytterhoeven <geert@...ux-m68k.org>
>> Signed-off-by: Laura Abbott <lauraa@...eaurora.org>
>
> Tested-by: Geert Uytterhoeven <geert@...ux-m68k.org>
>
>> ---
>> Geert, can you drop my other patch and give this a test to see if it fixes
>> your bootup problem?
>
> Thanks, works fine!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/