linux-kernel - Re: [PATCH 2/3] w1: use pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1403140033.14018.12.camel@joe-AO725>
Date:	Wed, 18 Jun 2014 18:07:13 -0700
From:	Joe Perches <joe@...ches.com>
To:	Fjodor Schelichow <fjodor.schelichow@...mail.com>
Cc:	Evgeniy Polyakov <zbr@...emap.net>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	David Fries <David@...es.net>,
	Michael Opdenacker <michael.opdenacker@...e-electrons.com>,
	Jingoo Han <jg1.han@...sung.com>, linux-kernel@...r.kernel.org,
	Roman Sommer <romsom2@...oo.de>, linux-kernel@...cs.fau.de
Subject: Re: [PATCH 2/3] w1: use pr_* instead of printk

On Thu, 2014-06-19 at 02:52 +0200, Fjodor Schelichow wrote:
> This patch replaces all calls to the "printk" function within the main "w1"
> directory by calls to the appropriate "pr_*" function thus addressing
> the following warning generated by the checkpatch script:
[]
> diff --git a/drivers/w1/w1_log.h b/drivers/w1/w1_log.h
[]
> @@ -29,8 +29,8 @@
>  #else
>  #  define assert(expr) \
>          if(unlikely(!(expr))) {				        \
> -        printk(KERN_ERR "Assertion failed! %s,%s,%s,line=%d\n",	\
> -	#expr, __FILE__, __func__, __LINE__);		        \
> +		pr_err("Assertion failed! %s,%s,%s,line=%d\n",	\
> +		#expr, __FILE__, __func__, __LINE__);		\
>          }

These macros should really be surrounded by a do { ... } while (0)


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/