lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Thu, 19 Jun 2014 03:44:42 -0700
From:	Tony Lindgren <tony@...mide.com>
To:	George Cherian <george.cherian@...com>
Cc:	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
	linux-omap@...r.kernel.org, gregkh@...uxfoundation.org,
	balbi@...com, zonque@...il.com, b-liu@...com
Subject: Re: [PATCH v6 1/5] usb: musb: core: Handle Babble condition only in
 HOST mode

* George Cherian <george.cherian@...com> [140526 02:25]:
> BABBLE and RESET share the same interrupt. The interrupt
> is considered to be RESET if MUSB is in peripheral mode and
> as a BABBLE if MUSB is in HOST mode.
> 
> Handle babble condition iff MUSB is in HOST mode.

Please get this into mainline kernel for v3.16-rc.

Fixes: ca88fc2ef0d7 (usb: musb: add a work_struct to recover from babble errors)

Tested-by: Tony Lindgren <tony@...mide.com>
 
> Signed-off-by: George Cherian <george.cherian@...com>
> ---
>  drivers/usb/musb/musb_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
> index 3c6043c..0ad9551 100644
> --- a/drivers/usb/musb/musb_core.c
> +++ b/drivers/usb/musb/musb_core.c
> @@ -849,7 +849,7 @@ b_host:
>  	}
>  
>  	/* handle babble condition */
> -	if (int_usb & MUSB_INTR_BABBLE)
> +	if (int_usb & MUSB_INTR_BABBLE && is_host_active(musb))
>  		schedule_work(&musb->recover_work);
>  
>  #if 0
> -- 
> 1.8.3.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists