linux-kernel - Re: [PATCH 6/7] pwm: st: Add new driver for ST's PWM IP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140619113259.GO32514@n2100.arm.linux.org.uk>
Date:	Thu, 19 Jun 2014 12:32:59 +0100
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Lee Jones <lee.jones@...aro.org>
Cc:	Thierry Reding <thierry.reding@...il.com>,
	linux-pwm@...r.kernel.org, kernel@...inux.com,
	devicetree@...r.kernel.org, srinivas.kandagatla@...il.com,
	patrice.chotard@...com, linux-kernel@...r.kernel.org,
	ajitpal.singh@...com, linux-arm-kernel@...ts.infradead.org,
	maxime.coquelin@...com
Subject: Re: [PATCH 6/7] pwm: st: Add new driver for ST's PWM IP

On Thu, Jun 19, 2014 at 09:44:04AM +0100, Lee Jones wrote:
> On Thu, 19 Jun 2014, Thierry Reding wrote:
> > On Wed, Jun 18, 2014 at 03:52:51PM +0100, Lee Jones wrote:
> > > +#include <linux/clk.h>
> > > +#include <linux/math64.h>
> > > +#include <linux/module.h>
> > > +#include <linux/of.h>
> > > +#include <linux/platform_device.h>
> > > +#include <linux/pwm.h>
> > > +#include <linux/regmap.h>
> > > +#include <linux/slab.h>
> > > +#include <linux/mfd/syscon.h>
> > > +#include <linux/time.h>
> > 
> > These should be sorted alphabetically.
> 
> Really? :)

Yes, as a general rule, for two reasons:

- It helps to reduce conflicts when two people add two different header
  files at a later date (provided they don't ignore the sorting and add
  them both at the end of the list.)

- It helps reduce the chance of having the same include listed twice
  (sometimes silently caused at git merge time) since it means if two
  people independently add the same include in the same place in the
  list, git will cope.  Eg, if one adds an include in one random place
  in the list, and someone else adds the same in another random place in
  the list, the result will be two includes of the same file.  If they're
  sufficiently far apart, git will not flag a conflict.

-- 
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/