lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 19 Jun 2014 21:56:44 +0900 From: Namhyung Kim <namhyung@...nel.org> To: Jiri Olsa <jolsa@...nel.org> Cc: linux-kernel@...r.kernel.org, Arnaldo Carvalho de Melo <acme@...nel.org>, Corey Ashford <cjashfor@...ux.vnet.ibm.com>, David Ahern <dsahern@...il.com>, Frederic Weisbecker <fweisbec@...il.com>, Ingo Molnar <mingo@...nel.org>, Paul Mackerras <paulus@...ba.org>, Peter Zijlstra <a.p.zijlstra@...llo.nl> Subject: Re: [PATCH 5/5] perf tools: Add report.show-headers config file option Hi Jiri, 2014-06-19 (목), 13:41 +0200, Jiri Olsa: > Adding report.show-headers config file option to setup > the appearance of the columns headers. > > Currently columns headers are displayed by default, following > lines in ~/.perfconfig file will disable that: > > [report] > show-headers = true This also applies to perf top, right? And it's TUI-specific. So how about calling it something like "tui.show-headers"? [SNIP] > @@ -35,6 +35,7 @@ struct symbol_conf symbol_conf = { > .demangle = true, > .cumulate_callchain = true, > .symfs = "", > + .show_headers = -1, Hmm.. why not just making it boolean and set it to true (like others)? Thanks, Namhyung > }; > > static enum dso_binary_type binary_type_symtab[] = { > diff --git a/tools/perf/util/symbol.h b/tools/perf/util/symbol.h > index 615c752..8f1854a 100644 > --- a/tools/perf/util/symbol.h > +++ b/tools/perf/util/symbol.h > @@ -139,6 +139,7 @@ struct symbol_conf { > *sym_from_list, > *sym_to_list; > const char *symfs; > + int show_headers; > }; > > extern struct symbol_conf symbol_conf; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists