lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Thu, 19 Jun 2014 09:25:36 -0400
From:	Tejun Heo <tj@...nel.org>
To:	Rasmus Villemoes <linux@...musvillemoes.dk>
Cc:	Christoph Lameter <cl@...ux-foundation.org>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: percpu: micro-optimize round-to-even

On Thu, Jun 19, 2014 at 12:02:29PM +0200, Rasmus Villemoes wrote:
> This change shaves a few bytes off the generated code.
> 
> Signed-off-by: Rasmus Villemoes <linux@...musvillemoes.dk>
> ---
>  mm/percpu.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/mm/percpu.c b/mm/percpu.c
> index 2ddf9a9..978097f 100644
> --- a/mm/percpu.c
> +++ b/mm/percpu.c
> @@ -720,8 +720,7 @@ static void __percpu *pcpu_alloc(size_t size, size_t align, bool reserved)
>  	if (unlikely(align < 2))
>  		align = 2;
>  
> -	if (unlikely(size & 1))
> -		size++;
> +	size += size & 1;

I'm not gonna apply this.  This isn't that hot a path.  It's not
worthwhile to micro optimize code like this.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists