linux-kernel - Re: [PATCH v2 10/18] ARM: dts: dra7xx-clocks: Add missing 32khz clocks used for PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53A2E507.7090405@ti.com>
Date:	Thu, 19 Jun 2014 16:26:31 +0300
From:	Tero Kristo <t-kristo@...com>
To:	Kishon Vijay Abraham I <kishon@...com>,
	<devicetree@...r.kernel.org>, <linux-doc@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-omap@...r.kernel.org>, <linux-pci@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
CC:	<arnd@...db.de>, <tony@...mide.com>, <jg1.han@...sung.com>,
	Rajendra Nayak <rnayak@...com>, Paul Walmsley <paul@...an.com>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Kumar Gala <galak@...eaurora.org>
Subject: Re: [PATCH v2 10/18] ARM: dts: dra7xx-clocks: Add missing 32khz clocks
 used for PHY

On 06/19/2014 04:23 PM, Kishon Vijay Abraham I wrote:
> Hi Tero,
>
> On Thursday 19 June 2014 04:46 PM, Tero Kristo wrote:
>> On 05/29/2014 09:38 AM, Kishon Vijay Abraham I wrote:
>>> Added missing 32khz clock used by PCIe PHY.
>>> The documention for this node can be found @ ../bindings/clock/ti/gate.txt.
>>
>> You can drop the node documentation ref, and rather add a TRM reference about
>> hardware details. Other than that, looks good to me.
>
> You mean something like why 32KHz clock is used (**PRCM.PCIE_32K_GFCLK (based
> on PRM.SYS_32K) for debounce and wakeup logic inside the PCIe1_PHY_RX**)? Or
> something like **Figure 26-19. PCIe PHY Subsystem Integration of DRA TRM vE
> shows how 32KHz clock is being used** ?

Just having a reference to the TRM version used and if you can provide a 
link to a figure or page where the clock integration is described should 
be good.

-Tero

>
> Thanks
> Kishon
>
>>
>> -Tero
>>
>>>
>>> Cc: Tony Lindgren <tony@...mide.com>
>>> Cc: Rajendra Nayak <rnayak@...com>
>>> Cc: Tero Kristo <t-kristo@...com>
>>> Cc: Paul Walmsley <paul@...an.com>
>>> Cc: Tony Lindgren <tony@...mide.com>
>>> Cc: Rob Herring <robh+dt@...nel.org>
>>> Cc: Pawel Moll <pawel.moll@....com>
>>> Cc: Mark Rutland <mark.rutland@....com>
>>> Cc: Kumar Gala <galak@...eaurora.org>
>>> Signed-off-by: Kishon Vijay Abraham I <kishon@...com>
>>> ---
>>>    arch/arm/boot/dts/dra7xx-clocks.dtsi |    8 ++++++++
>>>    1 file changed, 8 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/dra7xx-clocks.dtsi
>>> b/arch/arm/boot/dts/dra7xx-clocks.dtsi
>>> index 44993ec..e1bd052 100644
>>> --- a/arch/arm/boot/dts/dra7xx-clocks.dtsi
>>> +++ b/arch/arm/boot/dts/dra7xx-clocks.dtsi
>>> @@ -1165,6 +1165,14 @@
>>>            reg = <0x021c>, <0x0220>;
>>>        };
>>>
>>> +    optfclk_pciephy_32khz: optfclk_pciephy_32khz@...093b0 {
>>> +        compatible = "ti,gate-clock";
>>> +        clocks = <&sys_32k_ck>;
>>> +        #clock-cells = <0>;
>>> +        reg = <0x13b0>;
>>> +        ti,bit-shift = <8>;
>>> +    };
>>> +
>>>        optfclk_pciephy_div: optfclk_pciephy_div@...0821c {
>>>            compatible = "ti,divider-clock";
>>>            clocks = <&apll_pcie_ck>;
>>>
>>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/