lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 19 Jun 2014 16:42:19 +0200 From: Konrad Zapalowicz <bergo.torino@...il.com> To: Daniel Vetter <daniel.vetter@...ll.ch> Cc: "Nikula, Jani" <jani.nikula@...ux.intel.com>, Dave Airlie <airlied@...ux.ie>, intel-gfx <intel-gfx@...ts.freedesktop.org>, dri-devel <dri-devel@...ts.freedesktop.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] drivers/i915: Fix unnoticed failure of init_ring_common() On 06/19, Daniel Vetter wrote: > On Thu, Jun 19, 2014 at 4:35 PM, Daniel Vetter <daniel.vetter@...ll.ch> wrote: > > The actual bug we seem to have is blowing up on the ggtt_unpin in > > context_fini. Which is doubly-impossible: Gen4 doesn't have hw > > contexts, so should have dctx->obj == NULL. And ring init failures > > fail earlier so shouldn't even hit the context_fini code below the > > cleanup_gem: label in driver_load. Seriously confused here. > > Also please retest with latest upstream, we've made the ring init > failure non-letal for the driver. That should help you, too. > -Daniel Thanks for comments and I will resubmit the patch, still it is better to have it. /Konrad > -- > Daniel Vetter > Software Engineer, Intel Corporation > +41 (0) 79 365 57 48 - http://blog.ffwll.ch -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists