linux-kernel - Re: [PATCH] mm: percpu: micro-optimize round-to-even

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.11.1406190957030.2785@gentwo.org>
Date:	Thu, 19 Jun 2014 09:59:18 -0500 (CDT)
From:	Christoph Lameter <cl@...two.org>
To:	Tejun Heo <tj@...nel.org>
cc:	Rasmus Villemoes <linux@...musvillemoes.dk>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: percpu: micro-optimize round-to-even

On Thu, 19 Jun 2014, Tejun Heo wrote:

> Indeed, a patch?

Subject: percpu: Use ALIGN macro instead of hand coding alignment calculation

Signed-off-by: Christoph Lameter <cl@...ux.com>

Index: linux/mm/percpu.c
===================================================================
--- linux.orig/mm/percpu.c	2014-06-04 13:43:12.541466633 -0500
+++ linux/mm/percpu.c	2014-06-19 09:56:10.458023912 -0500
@@ -720,8 +720,7 @@ static void __percpu *pcpu_alloc(size_t
 	if (unlikely(align < 2))
 		align = 2;

-	if (unlikely(size & 1))
-		size++;
+	size = ALIGN(size, 2);

 	if (unlikely(!size || size > PCPU_MIN_UNIT_SIZE || align > PAGE_SIZE)) {
 		WARN(true, "illegal size (%zu) or align (%zu) for "
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/