lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Thu, 19 Jun 2014 08:59:27 -0700
From:	Joe Perches <joe@...ches.com>
To:	Rob Jones <rob.jones@...ethink.co.uk>
Cc:	linus.walleij@...aro.org, gnurou@...il.com, lgirdwood@...il.com,
	broonie@...nel.org, linux-gpio@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-kernel@...ethink.co.uk,
	ian.molton@...ethink.co.uk, ben.dooks@...ethink.co.uk,
	heiko@...ech.de
Subject: Re: [PATCH 3/4] drivers/base: devres.c: use devm_kmemdup() from
 with devm_kstrdup()

On Thu, 2014-06-19 at 16:46 +0100, Rob Jones wrote:
> Avoid code duplication by using devm_kmemdup() to copy data instead
> of having a separate loop within devm_kstrdup().
> 
> Reviewed-by: Ian Molton <ian.molton@...ethink.co.uk>
> Signed-off-by: Rob Jones <rob.jones@...ethink.co.uk>
[]
> diff --git a/drivers/base/devres.c b/drivers/base/devres.c
[]
> @@ -802,17 +802,10 @@ EXPORT_SYMBOL_GPL(devm_kmalloc);
>   */
>  char *devm_kstrdup(struct device *dev, const char *s, gfp_t gfp)
>  {
[]
> +	return devm_kmemdup(dev, s, (strlen(s) + 1), gfp);
>  }
>  EXPORT_SYMBOL_GPL(devm_kstrdup);

Making this static inline in the header and dropping
EXPORT_SYMBOL_GPL might be smaller code.

static inline
char *devm_kstrdup(struct device *dev, const char *s, gfp_t gfp)
{
	return devm_kmemdup(dev, s, strlen(s) + 1, gfp);
}


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists