lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <7h8uosyc3k.fsf@paris.lan> Date: Thu, 19 Jun 2014 11:43:11 -0700 From: Kevin Hilman <khilman@...aro.org> To: Doug Anderson <dianders@...omium.org> Cc: Wolfram Sang <wsa@...-dreams.de>, Kukjin Kim <kgene.kim@...sung.com>, Tomasz Figa <tomasz.figa@...il.com>, javier.martinez@...labora.co.uk, ch.naveen@...sung.com, jg1.han@...sung.com, jdelvare@...e.de, sjg@...gle.com, paul.gortmaker@...driver.com, standby24x7@...il.com, sachin.kamat@...aro.org, linux-i2c@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] i2c: exynos5: Properly use the "noirq" variants of suspend/resume Doug Anderson <dianders@...omium.org> writes: > The original code for the exynos i2c controller registered for the > "noirq" variants. However during review feedback it was moved to > SIMPLE_DEV_PM_OPS without anyone noticing that it meant we were no > longer actually "noirq" (despite functions named > exynos5_i2c_suspend_noirq and exynos5_i2c_resume_noirq). > > i2c controllers that might have wakeup sources on them seem to need to > resume at noirq time so that the individual drivers can actually read > the i2c bus to handle their wakeup. I suspect usage of the noirq variants pre-dates the existence of the late/early callbacks in the PM core, but based on the description above, I suspect what you actually want is the late/early callbacks. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists