linux-kernel - Re: [PATCH] staging: rtl8192 Check for Null return from dev_skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1403211103.2753.8.camel@joe-AO725>
Date:	Thu, 19 Jun 2014 13:51:43 -0700
From:	Joe Perches <joe@...ches.com>
To:	Nick Krause <xerofoify@...il.com>
Cc:	Greg KH <gregkh@...uxfoundation.org>, lisa@...apiadmin.com,
	Valentina Manea <valentina.manea.m@...il.com>,
	ben@...adent.org.uk, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8192 Check for Null return from
 dev_skb_alloc

On Thu, 2014-06-19 at 16:20 -0400, Nick Krause wrote:
> Hey Guys,
> So Sorry about wasting your time with bad patchs.
> I feel bad about that. I hope this patch is O.K.
> now. :(

It's not.

> > diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
[]
> > @@ -59,7 +58,9 @@ static bool fw_download_code(struct net_device *dev, u8 *code_virtual_address,
> >                         bLastIniPkt = 1;
> >
> >                 }
> > -
> > +               skb  = dev_alloc_skb(frag_length + 4);
> > +               if (!skb)
> > +                       return false;
> >                 skb  = dev_alloc_skb(frag_length + 4);

You're still wasting time and not thoroughly
reading your own patches.

You've duplicated the dev_alloc_skb line.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/