linux-kernel - Re: [PATCH] staging: android: binder: Fix 10 overlong lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140619224716.GA8223@kroah.com>
Date:	Thu, 19 Jun 2014 15:47:16 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Daniel Dressler <danieru.dressler@...il.com>
Cc:	devel@...verdev.osuosl.org, waydi1@...il.com,
	yangds.fnst@...fujitsu.com, serban.constantinescu@....com,
	linux-kernel@...r.kernel.org, arve@...roid.com,
	john.stultz@...aro.org, prtvar.b@...il.com
Subject: Re: [PATCH] staging: android: binder: Fix 10 overlong lines

On Sat, May 31, 2014 at 05:29:53PM -0600, Daniel Dressler wrote:
> This patch was made following Greg Kroah-Hartman's
> newbie guide. It is not intended to make any
> logical alterations to codeflow. Of note to reviews
> this patch switch's a call to kzalloc to kcalloc on
> line 2837
> 
> Neil Brown gave good advice on how to align
> the over-long function calls. He suggested
> using a single tab to indent the arguments.
> Like thus:
> var = function(
> 	arg1, arg2, arg3, arg4);
> 
> I intended to use the style he suggested but
> noticed much of the existing code instead
> aligns the overflow with the first argument
> and tries to give all arguments equal space.
> Like thus:
> var = function(arg1, arg2
> 	       arg3, arg4);
> 
> This second method uses spaces to align the
> arguments.
> 
> Taking a survey of the first 800 lines the
> following lines used each method:
> 
> Method #1: 666, 527, 572
> Method #2: 475, 495, 520, 545, 554, 582, 630,
>            677, 788
> 
> Thus to maintain consistancy this patch uses
> method #1. If method #1 is not acceptable
> please do not hesitate to say so.
> 
> Signed-off-by: Daniel Dressler <danieru.dressler@...il.com>
> ---
>  drivers/staging/android/binder.c | 32 ++++++++++++++++++++++----------
>  1 file changed, 22 insertions(+), 10 deletions(-)

This patch doesn't apply properly to my staging-next branch of the
staging.git tree :(

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/