linux-kernel - Re: [PATCH 5/5] perf tools: Add report.show-headers config file option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87r42k79nu.fsf@sejong.aot.lge.com>
Date:	Fri, 20 Jun 2014 08:37:57 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Jiri Olsa <jolsa@...nel.org>, linux-kernel@...r.kernel.org,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Corey Ashford <cjashfor@...ux.vnet.ibm.com>,
	David Ahern <dsahern@...il.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...nel.org>,
	Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [PATCH 5/5] perf tools: Add report.show-headers config file option

On Thu, 19 Jun 2014 18:51:13 +0200, Jiri Olsa wrote:
> On Thu, Jun 19, 2014 at 10:09:59PM +0900, Namhyung Kim wrote:
>> 2014-06-19 (목), 15:02 +0200, Jiri Olsa:
>> > On Thu, Jun 19, 2014 at 09:56:44PM +0900, Namhyung Kim wrote:
>> > > [SNIP]
>> > > > @@ -35,6 +35,7 @@ struct symbol_conf symbol_conf = {
>> > > >  	.demangle		= true,
>> > > >  	.cumulate_callchain	= true,
>> > > >  	.symfs			= "",
>> > > > +	.show_headers		= -1,
>> > > 
>> > > Hmm.. why not just making it boolean and set it to true (like others)?
>> > 
>> > I need 'unset' value, otherwise I dont know if the config
>> > option was unset by user or not touched at all
>> 
>> I don't understand why you need it..  isn't it enough to check the
>> config option before using the value?
>
> if config file option is not specified the show_headers
> value will be 'false' ... 

Confused.  What makes it to be false if its default value is true and
the config option is not specified?

Thanks,
Namhyung


> which will cause headers not
> to be displayed.. but they should be by default
>
> jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/