lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <1403151270.14018.17.camel@joe-AO725> Date: Wed, 18 Jun 2014 21:14:30 -0700 From: Joe Perches <joe@...ches.com> To: Nicholas Krause <xerofoify@...il.com> Cc: gregkh@...uxfoundation.org, lisa@...apiadmin.com, valentina.manea.m@...il.com, ben@...adent.org.uk, devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] staging: rtl8192e: check return value of dev_skb_alloc On Wed, 2014-06-18 at 22:24 -0400, Nicholas Krause wrote: > Checks if dev_skb_alloc returns Null in function, fw_download_code. > If the return value of dev_skb_alloc is NULL return false and exit > this function. Hello Nicholas. If you're going to try add these checks, please look at the code a bit more before submitting defective patches. > diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c [] > @@ -62,6 +62,8 @@ static bool fw_download_code(struct net_device *dev, u8 *code_virtual_address, > > skb = dev_alloc_skb(frag_length + 4); > memcpy((unsigned char *)(skb->cb), &dev, sizeof(dev)); > + if (!skb) > + return !rt_status; Umm, if you're going to check whether or not skb is NULL, do it before it's dereferenced as skb->cb. Oh, and get rid of rt_status and use return false; directly. > tcb_desc = (struct cb_desc *)(skb->cb + MAX_DEV_ADDR_SIZE); > tcb_desc->queue_index = TXCMD_QUEUE; > tcb_desc->bCmdOrInit = DESC_PACKET_TYPE_INIT; and change the end of function from: return rt_status; to: return true; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists