linux-kernel - Re: [PATCH 5/5] perf tools: Add report.show-headers config file option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140620080351.GD1218@krava.brq.redhat.com>
Date:	Fri, 20 Jun 2014 10:03:51 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Jiri Olsa <jolsa@...nel.org>, linux-kernel@...r.kernel.org,
	Corey Ashford <cjashfor@...ux.vnet.ibm.com>,
	David Ahern <dsahern@...il.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...nel.org>,
	Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [PATCH 5/5] perf tools: Add report.show-headers config file
 option

On Fri, Jun 20, 2014 at 08:46:58AM +0900, Namhyung Kim wrote:
> On Thu, 19 Jun 2014 18:58:15 +0200, Jiri Olsa wrote:
> > On Thu, Jun 19, 2014 at 12:28:43PM -0300, Arnaldo Carvalho de Melo wrote:
> >> Em Thu, Jun 19, 2014 at 09:56:44PM +0900, Namhyung Kim escreveu:
> >> > 2014-06-19 (목), 13:41 +0200, Jiri Olsa:
> >> > > Adding report.show-headers config file option to setup
> >> > > the appearance of the columns headers.
> >> > > 
> >> > > Currently columns headers are displayed by default, following
> >> > > lines in ~/.perfconfig file will disable that:
> >> > > 
> >> > >   [report]
> >> > >         show-headers = true
> >> > 
> >> > This also applies to perf top, right?  And it's TUI-specific.  So how
> >> > about calling it something like "tui.show-headers"?
> >> 
> >> Why should it be TUI specific? You either show the headers or you don't,
> >> in all UIs.
> >> 
> >> And also in all tools, I think, so I suggest putting it in some global,
> >> for all tools, section in the config file, i.e. something like
> >> all.show-headers.
> >
> > seems like so far we have 'core.' and 'hist.' as non-command specific
> > config sections (note '.core' does not hold any options yet)
> >
> > I can add another 'all.' section
> 
> I don't think it's a better name - it's too general.  If we really want
> to control all UI behavior I'd rather suggest 'ui.' section name.

I'm fine with 'ui'

> 
> Oh, I found that it'd somewhat clash with existing --header(-only)
> option in perf report. :-/

right, so how about:
   show-columns-headers
   show-columns-headings
   show-headings

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/