linux-kernel - Re: [PATCH 1/2] clocksource: arm_arch_timer: remove static from arch_timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 20 Jun 2014 11:52:17 +0100
From:	Mark Rutland <mark.rutland@....com>
To:	Heiko Stübner <heiko@...ech.de>
Cc:	Daniel Lezcano <daniel.lezcano@...aro.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <Pawel.Moll@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Arnd Bergmann <arnd@...db.de>,
	Matthias Brugger <matthias.bgg@...il.com>
Subject: Re: [PATCH 1/2] clocksource: arm_arch_timer: remove static from
 arch_timer_init

On Fri, Jun 20, 2014 at 11:44:11AM +0100, Heiko Stübner wrote:
> There exist SoCs that need some special setup procedure for their architected-timer
> to work. Therefore allow arch_timer_init to be called from such specialized
> clocksources.
> 
> Signed-off-by: Heiko Stuebner <heiko@...ech.de>
> ---
>  drivers/clocksource/arm_arch_timer.c | 2 +-
>  drivers/clocksource/arm_arch_timer.h | 7 +++++++
>  2 files changed, 8 insertions(+), 1 deletion(-)
>  create mode 100644 drivers/clocksource/arm_arch_timer.h
> 
> diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c
> index 5163ec1..55116d6 100644
> --- a/drivers/clocksource/arm_arch_timer.c
> +++ b/drivers/clocksource/arm_arch_timer.c
> @@ -635,7 +635,7 @@ static void __init arch_timer_common_init(void)
>  	arch_timer_arch_init();
>  }
>  
> -static void __init arch_timer_init(struct device_node *np)
> +void __init arch_timer_init(struct device_node *np)
>  {
>  	int i;
>  
> diff --git a/drivers/clocksource/arm_arch_timer.h b/drivers/clocksource/arm_arch_timer.h
> new file mode 100644
> index 0000000..af3974d
> --- /dev/null
> +++ b/drivers/clocksource/arm_arch_timer.h
> @@ -0,0 +1,7 @@
> +/*
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + */
> +
> +void __init arch_timer_init(struct device_node *np);

If we _really_ need this (which I hope we don't), we already have
include/clocksource/arm_arch_timer.h.

Mark.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/