linux-kernel - Re: [GIT PULL] EFI urgent fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 20 Jun 2014 14:39:19 +0100
From:	Leif Lindholm <leif.lindholm@...aro.org>
To:	Catalin Marinas <catalin.marinas@....com>
Cc:	Matt Fleming <matt@...sole-pimps.org>,
	"H. Peter Anvin" <hpa@...or.com>, Ingo Molnar <mingo@...nel.org>,
	"linux-efi@...r.kernel.org" <linux-efi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] EFI urgent fix

On Fri, Jun 20, 2014 at 10:28:48AM +0100, Catalin Marinas wrote:
> On Fri, Jun 20, 2014 at 10:00:08AM +0100, Matt Fleming wrote:
> > Please pull the following compiler warning fix. Sorry, I've been pretty
> > slow in getting this pull request sent. Multiple people have reported
> > hitting it and I've now received 4 patches for the same warning,
> 
> BTW, one of them is not just a simple warning but a bug. Pointer to
> "long" variable on the stack passed to a function that only takes a
> pointer to "int". We are probably lucky that we don't hit the bug on
> arm64.
> 
> Anyway, thanks for pushing the fix.
> 
> (and lesson learnt not to trust the ARM EFI_STUB developers, won't name
> them, with properly testing their code ;))

The code was tested and showed no runtime problems - but I did manage
to miss the warnings.

I did post an alternative patch for one half of this a week before
anyone else, but that one seems to have been ignored, even by gmane:
http://www.spinics.net/lists/linux-efi/msg03924.html

That form will still be required for the 32-bit arm support, since
strncmp is not available in the zImage.

/
    Leif
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/