lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 20 Jun 2014 17:58:45 +0200 From: Borislav Petkov <bp@...en8.de> To: Boris Ostrovsky <boris.ostrovsky@...cle.com> Cc: tony.luck@...el.com, linux-kernel@...r.kernel.org, linux-edac@...r.kernel.org, mattieu.souchaud@...e.fr Subject: Re: [PATCH] x86/mce: Don't unregister CPU hotplug notifier in error path On Fri, Jun 20, 2014 at 11:41:27AM -0400, Boris Ostrovsky wrote: > Only in the sense that on Xen misc_register() often fails. But any > failure on baremetal will result in the same behavior. Ok, thanks for explaining the details. > Right. And I think we shouldn't because we leave undeleted timers. I wonder if we could simply move the oneliner: __register_hotcpu_notifier(&mce_cpu_notifier); to mcheck_init()? We don't need any locking there because we're pre-SMP then and from looking at notifier_chain_register(), it seems there's nothing special that needs initializing for the call to be too early - we're simply adding the callback to a list... Hmm, because if that would work, the fix is almost trivial. :) -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists