linux-kernel - Re: [PATCH] staging: rtl8192e: check return value of dev_skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 20 Jun 2014 12:31:42 -0400
From:	Nick Krause <xerofoify@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Greg KH <gregkh@...uxfoundation.org>,
	Valentina Manea <valentina.manea.m@...il.com>,
	lisa@...apiadmin.com, ben@...adent.org.uk,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8192e: check return value of dev_skb_alloc

This patch is old I thought I fixed it and resent.
Cheers Nick

On Thu, Jun 19, 2014 at 5:25 PM, Joe Perches <joe@...ches.com> wrote:
> On Thu, 2014-06-19 at 15:29 -0400, Nicholas Krause wrote:
>
>> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
> []
>> @@ -59,7 +58,8 @@ static bool fw_download_code(struct net_device *dev, u8 *code_virtual_address,
>>                       bLastIniPkt = 1;
>>
>>               }
>> -
>> +             if (!skb)
>> +                     return false;
>>               skb  = dev_alloc_skb(frag_length + 4);
>
> Nick.
>
> You may have compiled this, but it's obvious you
> haven't tested it.
>
> Please stop sending patches until you can verify what
> you're doing with the code.
>
> Please train a few more of your neurons for coding.
>
> It takes some time and some practice but please don't
> practice on linux-kernel.
>
> Use google to find some other suitable forums like
> http://cboard.cprogramming.com/c-programming/
>
> Back to your patch:
>
>         if (!skb)
>                 return false;
>
> must go _after_
>
>         skb = dev_alloc_skb(frag_length + 4);
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/