linux-kernel - Re: [PATCH] Staging: serqt_usb2: fixed frivolous else statement warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140620164347.GA23197@kroah.com>
Date:	Fri, 20 Jun 2014 09:43:47 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Vincent Heuken <me@...centheuken.com>
Cc:	thomas_75@...e-mail.net, himangi774@...il.com,
	paul.gortmaker@...driver.com, aybuke.147@...il.com, arnd@...db.de,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: serqt_usb2: fixed frivolous else statement
 warnings

On Fri, Jun 20, 2014 at 09:31:28AM -0700, Vincent Heuken wrote:
> This is a patch to the serqt_usb2.c file that fixes two instances
> of the following checkpatch.pl warning:
> WARNING: else is not generally useful after a break or return
> 
> Signed-off-by: Vincent Heuken <me@...centheuken.com>
> ---
>  drivers/staging/serqt_usb2/serqt_usb2.c | 47 +++++++++++++++++----------------
>  1 file changed, 24 insertions(+), 23 deletions(-)
> 
> diff --git a/drivers/staging/serqt_usb2/serqt_usb2.c b/drivers/staging/serqt_usb2/serqt_usb2.c
> index 998c384..98e9736 100644
> --- a/drivers/staging/serqt_usb2/serqt_usb2.c
> +++ b/drivers/staging/serqt_usb2/serqt_usb2.c
> @@ -981,9 +981,8 @@ static void qt_block_until_empty(struct tty_struct *tty,
>  		if (wait == 0) {
>  			dev_dbg(&qt_port->port->dev, "%s - TIMEOUT", __func__);
>  			return;
> -		} else {
> -			wait = 30;
>  		}
> +		wait = 30;
>  	}
>  }
>  
> @@ -1130,27 +1129,29 @@ static int qt_ioctl(struct tty_struct *tty,
>  			/* this never wakes up */
>  			interruptible_sleep_on(&qt_port->msr_wait);
>  #endif
> +
> +			char diff;

A variable definition should be at the beginning of the function, not in
the middle.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/