[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAPnjgZ1=J+4GC6r1piVcmEbHJUJnM-N0jZmnhOQS5fNTGUySaA@mail.gmail.com>
Date: Thu, 19 Jun 2014 21:45:07 -0600
From: Simon Glass <sjg@...omium.org>
To: Doug Anderson <dianders@...omium.org>
Cc: Lee Jones <lee.jones@...aro.org>,
Andrew Bresticker <abrestic@...omium.org>,
Stephen Warren <swarren@...dotorg.org>,
Olof Johansson <olof@...om.net>,
Sonny Rao <sonnyrao@...omium.org>,
linux-samsung-soc <linux-samsung-soc@...r.kernel.org>,
Javier Martinez Canillas <javier.martinez@...labora.co.uk>,
Bill Richardson <wfrichar@...omium.org>,
Wolfram Sang <wsa@...-dreams.de>,
Mark Brown <broonie@...nel.org>,
Dmitry Torokhov <dmitry.torokhov@...il.com>,
Samuel Ortiz <sameo@...ux.intel.com>,
Geert Uytterhoeven <geert@...ux-m68k.org>,
"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
lk <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 10/10] mfd: cros_ec: move EC interrupt to cros_ec_keyb
On 18 June 2014 12:14, Doug Anderson <dianders@...omium.org> wrote:
> From: Andrew Bresticker <abrestic@...omium.org>
>
> If we receive EC interrupts after the cros_ec driver has probed, but
> before the cros_ec_keyb driver has probed, the cros_ec IRQ handler
> will not run the cros_ec_keyb notifier and the EC will leave the IRQ
> line asserted. The cros_ec IRQ handler then returns IRQ_HANDLED and
> the resulting flood of interrupts causes the machine to hang.
>
> Since the EC interrupt is currently only used for the keyboard, move
> the setup and handling of the EC interrupt to the cros_ec_keyb driver.
>
> Signed-off-by: Andrew Bresticker <abrestic@...omium.org>
> Signed-off-by: Doug Anderson <dianders@...omium.org>
Reviewed-by: Simon Glass <sjg@...omium.org>
We never needed an EC-level interrupt, and have shipped at least three
products now that use this code, so I think it is safe enough to
declare that we won't need it.
Regards,
Simon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists