linux-kernel - Re: [PATCH 3.15.1] i82975x_edac: fix dram layout inits and style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140620182951.GH11391@pd.tnic>
Date:	Fri, 20 Jun 2014 20:29:51 +0200
From:	Borislav Petkov <bp@...en8.de>
To:	Arvind R <arvino55@...il.com>
Cc:	linux-edac <linux-edac@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3.15.1] i82975x_edac: fix dram layout inits and style

On Fri, Jun 20, 2014 at 09:26:27PM +0530, Arvind R wrote:
> Subject: [PATCH 3.15.1] i82975x_edac: fix dram layout inits and style
> 
> rewrite dram layout initialisation differently based on symmetry
> of organisation. And a long pending cleanup.

Yeah, this patch is trying to do a lot of things at once and could use some
splitting into single logical changes with proper explanations in their
respective commit messages *why* the changes are needed.

Also, do you test those changes on real hardware?

Also, you have some strange coding style like

+#define^II82975X_NR_CSROWS_PER_CHANNEL

 (there's a tab between the "define" and the name)

+^I^Iif (is_symmetric)^I{$

 (tab between closing bracket and opening curly brace)

and so on. Please use single spaces like the rest of the kernel code.

Use Documentation/CodingStyle as a guide.

Thanks.

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/