linux-kernel - Re: [PATCH] x86/mce: Don't unregister CPU hotplug notifier in error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53A48DF6.9020503@oracle.com>
Date:	Fri, 20 Jun 2014 15:39:34 -0400
From:	Boris Ostrovsky <boris.ostrovsky@...cle.com>
To:	Borislav Petkov <bp@...en8.de>
CC:	tony.luck@...el.com, linux-kernel@...r.kernel.org,
	linux-edac@...r.kernel.org, mattieu.souchaud@...e.fr
Subject: Re: [PATCH] x86/mce: Don't unregister CPU hotplug notifier in error
 path

On 06/20/2014 01:52 PM, Borislav Petkov wrote:
> On Fri, Jun 20, 2014 at 12:16:39PM -0400, Boris Ostrovsky wrote:
>> But I think you still need to do the dance in the notifier to make
>> sure you are not trying to add/remove device if mcheck_init_device()
>> had failed earlier.
> mce_device_remove should be smart enough. Hint: mce_device_initialized
> cpumask.

What about mce_device_add()?

-boris

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/