linux-kernel - Re: [PATCH v5 01/15] thunderbolt: Add initial cactus ridge NHI support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 20 Jun 2014 21:45:45 +0200
From:	Andreas Noever <andreas.noever@...il.com>
To:	Paul Bolle <pebolle@...cali.nl>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Matthew Garrett <matthew.garrett@...ula.com>,
	Greg KH <greg@...ah.com>, Bjorn Helgaas <bhelgaas@...gle.com>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>
Subject: Re: [PATCH v5 01/15] thunderbolt: Add initial cactus ridge NHI support

On Fri, Jun 20, 2014 at 9:41 AM, Paul Bolle <pebolle@...cali.nl> wrote:
> On Tue, 2014-06-03 at 22:03 +0200, Andreas Noever wrote:
>> Thunderbolt hotplug is supposed to be handled by the firmware. But Apple
>> decided to implement thunderbolt at the operating system level. The
>> firmare only initializes thunderbolt devices that are present at boot
>> time. This driver enables hotplug of thunderbolt of non-chained
>> thunderbolt devices on Apple systems with a cactus ridge controller.
>>
>> This first patch adds the Kconfig file as well the parts of the driver
>> which talk directly to the hardware (that is pci device setup, interrupt
>> handling and RX/TX ring management).
>>
>> Signed-off-by: Andreas Noever <andreas.noever@...il.com>
>> ---
>
> This patch landed in today's linux-next (next-20140620).
>
>> [...]
>> --- /dev/null
>> +++ b/drivers/thunderbolt/Kconfig
>> @@ -0,0 +1,12 @@
>> +menuconfig THUNDERBOLT
>> +     tristate "Thunderbolt support for Apple devices"
>> +     default no
>
> That should have been "default n". But "n" is the default anyway, so I'd
> say this line might as well be dropped. Should I draft the trivial patch
> to do that?

Not necessary. A patch has already been send.

Andreas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/