linux-kernel - Re: [PATCH] staging: rtl8192 Check for Null return from dev_skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 20 Jun 2014 22:53:34 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Nicholas Krause <xerofoify@...il.com>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	lisa@...apiadmin.com, ben@...adent.org.uk,
	valentina.manea.m@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8192 Check for Null return from dev_skb_alloc

On Fri, Jun 20, 2014 at 12:49:55PM -0400, Nicholas Krause wrote:
> Checks for Null return from dev_skb_alloc if it returns Null,
> fw_download returns false. Otherwise it returns true.Also
> removed rt_status due to returning true of false directly.
> 
> Signed-off-by: Nicholas Krause <xerofoify@...il.com>
> ---

What is this?  This patch is really bad and also doesn't apply.  Greg
already told you not to send any more patches until next week so it's
just going to be ignored...

Please slow down and don't send this again until it is correct.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/